-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmfMetricPublisher class added #5752
Open
Fred1155
wants to merge
19
commits into
feature/master/emf-metric-publisher
Choose a base branch
from
bole/EMFMetricPublisher
base: feature/master/emf-metric-publisher
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
06e8f84
EmfMetricPublisher class with basic unit test added
Fred1155 1e08463
Edge cases handled
Fred1155 d073d86
javadoc for class added
Fred1155 cf0af99
merge master branch
Fred1155 5e34796
Java doc for methods added
Fred1155 9f221ff
Merge branch 'feature/master/emf-metric-publisher' into bole/EMFMetri…
Fred1155 c8ea4aa
minor unit test changes
Fred1155 79cf7d4
Merge branch 'bole/EMFMetricPublisher' of github.com:aws/aws-sdk-java…
Fred1155 04c837f
Change from using jacksonCore directly to using jsonWriter
Fred1155 2920596
EmfMetricConfiguration class added
Fred1155 c79e15f
MetricEmfConverter class added
Fred1155 e9320b0
new module checklist done
Fred1155 94e70a8
checkStyle fixed
Fred1155 9254b13
minor build problem fixed
Fred1155 980fdd6
internal package added
Fred1155 6b36d4e
fixed the issue passing raw objects
Fred1155 02a1036
added java clock to unit test
Fred1155 bb7f690
added unit test for publish method
Fred1155 f3084f3
minor changes
Fred1155 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"). | ||
| ~ You may not use this file except in compliance with the License. | ||
| ~ A copy of the License is located at | ||
| ~ | ||
| ~ http://aws.amazon.com/apache2.0 | ||
| ~ | ||
| ~ or in the "license" file accompanying this file. This file is distributed | ||
| ~ on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| ~ express or implied. See the License for the specific language governing | ||
| ~ permissions and limitations under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>metric-publishers</artifactId> | ||
| <version>2.29.34-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>emf-metric-publisher</artifactId> | ||
| <name>AWS Java SDK :: Metric Publishers :: Emf</name> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <properties> | ||
| <jre.version>1.8</jre.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>sdk-core</artifactId> | ||
Fred1155 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>annotations</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>third-party-jackson-core</artifactId> | ||
Fred1155 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to change it now, but we should discuss it in API surface area review. Should we rename it to
emf-metric-logger, since technically it's not publishing metrics?