Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos - Singer -> Signer #5714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix typos - Singer -> Signer #5714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bef71c
Fix typos - Singer -> Signer
rhowe Nov 18, 2024
447632f
Merge branch 'master' into less-karaoke
dagnir Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...a/software/amazon/awssdk/services/polly/internal/presigner/DefaultPollyPresignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ void presign_requestLevelCredentials_honored() {
}

@Test
void presign_requestLevelSingerAndCredentials_honored() {
void presign_requestLevelSignerAndCredentials_honored() {
IdentityProvider<AwsCredentialsIdentity> requestCedentialsProvider = StaticCredentialsProvider.create(
AwsBasicCredentials.create("akid2", "skid2")
);
Expand Down
4 changes: 2 additions & 2 deletions ...ware/amazon/awssdk/services/s3/internal/plugins/S3OverrideAuthSchemePropertiesPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void configureClient(SdkServiceClientConfiguration.Builder config) {
if (addConfiguredProperties(option, params)) {
AuthSchemeOption.Builder builder = option.toBuilder();
identityProperties.forEach((k, v) -> putIdentityProperty(builder, k, v));
signerProperties.forEach((k, v) -> putSingerProperty(builder, k, v));
signerProperties.forEach((k, v) -> putSignerProperty(builder, k, v));
result.add(builder.build());
} else {
result.add(option);
Expand All @@ -116,7 +116,7 @@ private <T> void putIdentityProperty(AuthSchemeOption.Builder builder, IdentityP
}

@SuppressWarnings("unchecked")
private <T> void putSingerProperty(AuthSchemeOption.Builder builder, SignerProperty<?> key, Object value) {
private <T> void putSignerProperty(AuthSchemeOption.Builder builder, SignerProperty<?> key, Object value) {
// Safe because of Builder#putSignerProperty
builder.putSignerProperty((SignerProperty<T>) key, (T) value);
}
Expand Down