DynamoDB Enhanced - Change to use regex pattern for the attribute name cleaner #5677
+10
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Applin
previously approved these changes
Oct 25, 2024
|
Running the unit tests, two of them are failing in the codebuild jobs:
Notably, they check that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The attribute name sanitizer checked for a specific list of special characters, but the list was not comprehensive of all the valid special characters for a dynamo attribute name.
Attribute names with a character that was valid but not in the list would get an error like
Customers submitted issues asking to add a new special character to the list (#3058 | #3139 | #3945 | #5603). This change will help prevent similar issues in the future.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
License