Adds the user agent appId metadata tag #5636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenedhryn
changed the title
davidh44
approved these changes
Oct 2, 2024
...k-core/src/main/java/software/amazon/awssdk/core/client/builder/SdkDefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
...k-core/src/main/java/software/amazon/awssdk/core/internal/useragent/SdkUserAgentBuilder.java
Outdated
Show resolved
Hide resolved
|
zoewangg
reviewed
Oct 4, 2024
| * This configuration option supersedes {@link SdkAdvancedClientOption#USER_AGENT_PREFIX} and | ||
| * {@link SdkAdvancedClientOption#USER_AGENT_SUFFIX} and should be used instead of those options. | ||
| */ | ||
| default B appId(String appId) { |
There was a problem hiding this comment.
Should we add this to ClientOverrideConfiguration instead?
zoewangg
reviewed
Oct 4, 2024
...k-core/src/main/java/software/amazon/awssdk/core/client/builder/SdkDefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
Comment on lines
+30
to
+31
| private Supplier<ProfileFile> profileFile; | ||
| private String profileName; |
| @@ -124,4 +134,12 @@ private static void appendAdditionalJvmMetadata(StringBuilder builder, SystemUse | |||
| appendNonEmptyField(builder, METADATA, lang); | |||
| } | |||
| } | |||
|
|
|||
| private static void checkLengthAndWarn(String appId) { | |||
| if (appId.length() > 50) { | |||
There was a problem hiding this comment.
Just to double check, is this only logged once?
There was a problem hiding this comment.
Yes, it's only logged once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AWS SDKs have added the
appIdmetadata tag which allows users to set an identifier for their application that is added to the user agent string for every request. This PR adds the feature to the AWS SDK for Java v2.Modifications
appIdas a client param inSdkDefaultClientBuilderappIdin environment variables, system settings and config files, and a resolver for determining if any such system value exists.Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License