[DO NOT MERGE] Feat flex checksum #2808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 25, 2024 17:59
lucix-aws
reviewed
Sep 26, 2024
lucix-aws
reviewed
Sep 26, 2024
lucix-aws
reviewed
Sep 26, 2024
added 4 commits
September 29, 2024 16:53
Madrigal
reviewed
Sep 30, 2024
lucix-aws
reviewed
Sep 30, 2024
added 3 commits
October 1, 2024 15:25
Madrigal
reviewed
Oct 2, 2024
service/internal/checksum/middleware_compute_input_checksum_test.go
Outdated
Show resolved
Hide resolved
Madrigal
reviewed
Oct 7, 2024
lucix-aws
reviewed
Oct 7, 2024
lucix-aws
reviewed
Oct 7, 2024
added 2 commits
October 7, 2024 17:42
merge main into branch
lucix-aws
reviewed
Oct 8, 2024
lucix-aws
approved these changes
Oct 8, 2024
Madrigal
approved these changes
Oct 8, 2024
lucix-aws
reviewed
Oct 21, 2024
wty-Bryant
force-pushed
the
feat-flex-checksum
branch
from
e277468 to
59e520b
Compare
added 2 commits
November 22, 2024 14:14
Madrigal
reviewed
Nov 25, 2024
added 3 commits
November 26, 2024 14:15
merge main into branch
Madrigal
approved these changes
Nov 26, 2024
added 9 commits
December 6, 2024 19:14
merge main into this branch
merge main into branch
merge main into branch
Madrigal
reviewed
Dec 18, 2024
|
|
||
| // ID provides the middleware identifier | ||
| func (m *RequestChecksumMetricsTracking) ID() string { | ||
| return "AWSChecksum:RequestMetricsTracking" |
There was a problem hiding this comment.
[observation] we don't follow this pattern of x:yon other middlewares, but I like how you used it here
| @@ -0,0 +1,169 @@ | |||
| //go:build go1.16 | |||
There was a problem hiding this comment.
- Why do we need to duplicate the user agent test? If we just want to test that it includes the features we're interested in, I wouldn't duplicate the whole test but just check that the user agent includes the features we're interested in
- Why do we put this under
go:buildtags? - If we need to do the above, can we change this to go 1.21?
added 2 commits
December 18, 2024 16:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add client cfg to opt-in/out checksum calculation/validation, change default algorithm to calculate checksum