fix : Fix flexible array member allocation #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected allocation of `nccl_net_ofi_schedule_t` to account for flexible array member. The previous implementation did not allocate enough memory for the flexible array `xfer_info` elements, leading to potential out-of-bounds access.
arunkarthik-akkart
force-pushed
the
rrx2
branch
from
af58921
to
28ff1e9
Compare
|
nit on the commit message, it was allocating more memory than necessary ( |
aws-nslick
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected allocation of
nccl_net_ofi_schedule_tto account for flexible array member. The previous implementation did not allocate enough memory for the flexible arrayxfer_infoelements, leading to potential out-of-bounds access.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.