fix(init): fix sendrecv fallback logic #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
159bfed introduced changes to the way that initialization and protocol selection works. This commit corrects some duplicated print statements that refer to rdma when they meant to refer to sendrecv protocol, and also ensures that the branch for doing first-stage sendrecv initialization is taken in the case that RDMA initialization fails for any reason, such that it can be used as a fallback. Also ensure that if either the selected protocol string or the plugin is null, that initialization is aborted rather than segfaulting. Signed-off-by: Nicholas Sielicki <[email protected]>
rauteric
approved these changes
Sep 28, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
159bfed introduced changes to the way that initialization and protocol selection works. This commit corrects some duplicated print statements that refer to rdma when they meant to refer to sendrecv protocol, and also ensures that the branch for doing first-stage sendrecv initialization is taken in the case that RDMA initialization fails for any reason, such that it can be used as a fallback. Also ensure that if either the selected protocol string or the plugin is null, that initialization is aborted rather than segfaulting. Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
159bfed introduced changes to the way that initialization and protocol
selection works. This commit corrects some duplicated print statements
that refer to rdma when they meant to refer to sendrecv protocol, and
also ensures that the branch for doing first-stage sendrecv
initialization is taken in the case that RDMA initialization fails for
any reason, such that it can be used as a fallback. Also ensure that if
either the selected protocol string or the plugin is null, that
initialization is aborted rather than segfaulting.
Signed-off-by: Nicholas Sielicki [email protected]