-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdma: add separate bounce buffer freelist for data (eager) messages #614
Open
rauteric
wants to merge
2
commits into
aws:master
Choose a base branch
from
rauteric:fl-separate-pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
force-pushed
the
fl-separate-pr
branch
2 times, most recently
from
September 19, 2024 23:09
19af9ec
to
512366e
Compare
rauteric
changed the title
rdma: add separate bounce buffer for data (eager messages)
rdma: add separate bounce buffer freelist for data (eager) messages
Sep 19, 2024
bwbarrett
reviewed
Sep 19, 2024
rauteric
force-pushed
the
fl-separate-pr
branch
from
October 2, 2024 23:36
512366e
to
6cbe500
Compare
The CI failure(s) are real:
Need to fix up some asserts. |
rauteric
force-pushed
the
fl-separate-pr
branch
from
October 3, 2024 19:46
6cbe500
to
3494556
Compare
Separate out bounce buffer freelists into a smaller-sized freelist for control messages and a larger size for data (eager) messages Also refactor bounce buffer freelists to be per-rail instead of shared across all rails. Parameters `min_posted_bounce_buffers` and `max_posted_bounce_buffers` are now per-rail values. Signed-off-by: Eric Raut <[email protected]>
rauteric
force-pushed
the
fl-separate-pr
branch
from
October 3, 2024 19:48
3494556
to
bf176e6
Compare
Rebased on master |
bot:aws:retest |
1 similar comment
bot:aws:retest |
bwbarrett
reviewed
Oct 4, 2024
Make posted buffer counts for control and eager bounce recv buffers separately configurable, and set a higher count for ctrl buffers. Signed-off-by: Eric Raut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out bounce buffer freelists into a smaller-sized freelist for
control messages and a larger size for data (eager) messages
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.