Fixes to error path in tests #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nccl_message_transfer and ring tests are overwriting in the cleanup the error value returned from previous calls. This is making the tests quite worthless, because if a function fails the returned error will be overwritten by the deallocate_buffer call, so if the deallocation is successful, the tests succeeds. This commit fixes that by using a different variable for the return values in the cleanup and makes the test fail if either a function call fails, or the cleanup fails, or both. Signed-off-by: Amedeo Sapio <[email protected]>
The exposed closeSend function points to blocked_send_close() which, in turn calls send_close(). The value returned by send_close was ignored, this commit is passing that value back to blocked_send_close. Signed-off-by: Amedeo Sapio <[email protected]>
AmedeoSapio
added
the
BuildTriggerRequest
rajachan
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccl_message_transfer and ring tests are overwriting in the cleanup the error value
returned from previous calls. This is making the tests quite worthless,
because if a function fails the returned error will be overwritten by the
deallocate_buffer call, so if the deallocation is successful, the tests
succeeds. This PR fixes that by using a different variable for the
return values in the cleanup and makes the test fail if either a function
call fails, or the cleanup fails, or both.
While testing this, I also noticed that we were ignoring the return value of
send_close(), so I am also fixing that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.