Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend range of communicator IDs for the RDMA protocol #367

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Extend range of communicator IDs for the RDMA protocol #367

merged 2 commits into from
Mar 31, 2024

Commits on Mar 30, 2024

  1. rdma: msgbuff can use any bit-width for msg_seq_num 

    This is changing the msgbuff so that it can support any number of bits for
the sequence number, not just 16.
This is in preparation to increase the range of comm IDs, which requires
changing the number of bits used for the msg_seq_num.
To fit a larger comm ID in the immediate data, the message sequence number
bit-width must be reduced.

With the 16 bits msg_seq_num the msgbuff relied on the wraparound of 16 bits
integers, so to reduce the number of bits of msg_seq_num we need to make the
wrapping around explicit and implement a distance function to deal with the
wraparound case. This makes the msgbuff more generic, as it can now support
any msg_seq_num space and any number of inflight messages, as long as they
are powers of 2.

This also extended the msgbuff unit test to test the case when message sequence
numbers wrap around.

Signed-off-by: Amedeo Sapio <[email protected]>
    @AmedeoSapio
    AmedeoSapio committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    a5967dd View commit details
    Browse the repository at this point in the history

  2. rdma: extended range of communicator IDs 

    Changing the number of bits used for the communicator ID from 12 to 18 to reduce
the chance of running out of comm IDs.

To fit a larger comm ID in the immediate data, the message sequence number
has been reduced from 16 bits to 10, which is still more than enough since
usually the number of inflight messages is not that high.
The msg_seq_num space can be further reduced if needed.

Signed-off-by: Amedeo Sapio <[email protected]>
    @AmedeoSapio
    AmedeoSapio committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    382d001 View commit details
    Browse the repository at this point in the history