Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused sts v2 dependency #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vaisharma
Copy link
Contributor

Description of changes:
The sts V2 dependency is not needed for the package. So removing it.

@guizmaii guizmaii mentioned this pull request Jan 31, 2023
@sayantacC
Copy link
Contributor

I think this change is not safe. If I remember correctly, the v2 sts and sso dependencies are needed at runtime if an aws profile is used that depends on a role or single signon credential. The v2 sdk which is used to load the profile based credentials tries lazy loading them from the classpath at runtime. So, we need to still have the v2 sts and sso dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants