Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to pass awsAccessKeyId awsSecretAccessKey. They can spec… #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

limithot
Copy link

Issue #, if available:

Description of changes:
Allow users to pass awsAccessKeyId awsSecretAccessKey. They can specify awsAccessKeyId=access-key-id awsSecretAccessKey=secret-access-key as an option on the sasl.jaas.config

add AwsBasicCredentialsProvider.java
and add MSKCredentialProvider.ProviderBuilder.getAwsBasicCredentialProvider() method to MSKCredentialProvider.java

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ify awsAccessKeyId=access-key-id awsSecretAccessKey=secret-access-key as an option on the sasl.jaas.config
@limithot limithot requested a review from a team as a code owner August 30, 2023 02:26
@sankalpbhatia
Copy link
Contributor

sankalpbhatia commented Aug 31, 2023

Hi @limithot, Thanks for the PR. May we know what use case are you trying to solve with this PR? It seems that one of the existing mechanisms (either awsProfileName or the "no jaas config option" mechanism) would work for your use case?

@limithot
Copy link
Author

limithot commented Aug 31, 2023

Hi, @sankalpbhatia ,
We need to use multiple credentials in our application(service). Each of credentials could be applied and switched by user's selection in runtime . And sometimes new credentials could be add. The way of using 'awsProfileName' mechanism could not meet with our requirements.

Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants