Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ML-KEM's internal header files to use unique include guards #2078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewhop
Copy link
Contributor

Description of changes:

Inspired by the issues in #2072 this PR update's ML-KEM's include guards to use unique names to avoid any future issues.

Call-outs:

Future PRs could also prefix more of the functions.

Testing:

Existing tests will cover any issues.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner December 23, 2024 20:48
@andrewhop andrewhop requested review from jakemas and dkostic December 23, 2024 20:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (acf5220) to head (890396b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
+ Coverage   78.73%   78.76%   +0.03%     
==========================================
  Files         598      598              
  Lines      103650   103650              
  Branches    14718    14719       +1     
==========================================
+ Hits        81609    81641      +32     
+ Misses      21389    21357      -32     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants