Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge check for vulnerabilities to main #127

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Merge check for vulnerabilities to main #127

merged 2 commits into from
Jun 6, 2024

Conversation

valerena
Copy link
Contributor

@valerena valerena commented Jun 5, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@valerena valerena requested a review from seshubaws June 5, 2024 23:23

check-binaries: prep-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this, we could run the make command or the workflow to check for vulnerabilities? If so, do we need both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I fully understand the question, so let me know if this answers it. Now it will be possible to manually do make check-binaries in your local environment if you want to check locally without waiting for the GitHub action to run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's what I meant

@valerena valerena merged commit 394ab66 into main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants