Add automatic vulnerabilities check for released binaries #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seshubaws
reviewed
May 23, 2024
.github/workflows/check-binaries.yml
Outdated
| id: check-binaries | ||
| run: | | ||
| make check-binaries | ||
| - if: always() && failure() # Failure means there are vulnerabilities |
There was a problem hiding this comment.
What is always() checking for? Edit: I see in the docs it's to have it run even if a previous step fails (https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions) maybe we could add that as a comment here as well?
seshubaws
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Run a vulnerability check over the released binaries.
If there are vulnerabilities in the latest released binaries, then create an issue to call this out. Before creating the ticket, check if the vulnerabilities still exist when rebuilding the binaries with the same code, and include that info in the new issue.
Example issue: valerena#4
There's an improvement to be made to only create the issue if no issue has been created already. That's coming as a future improvement.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.