Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user-defined client context #110

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Allow for user-defined client context #110

merged 1 commit into from
Apr 29, 2024

Conversation

mcieno
Copy link
Contributor

@mcieno mcieno commented Feb 9, 2024

Issue #, if available:
Fixes #74 (and enables for aws/aws-sam-cli#1177)

Description of changes:
As explained in the Lambda Invoke documentation, the client context is passed base64-encoded in the X-Amz-Client-Context header.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@valerena
Copy link
Contributor

valerena commented Apr 1, 2024

Thank for your contribution! Would you be able to add integration tests for this behavior? (on test/integration/local_lambda/test_end_to_end.py)

(Make sure that you get the latest code, because the tests have been refactored a little lately)

@mcieno
Copy link
Contributor Author

mcieno commented Apr 24, 2024

Thanks @valerena. Rebased and aligned test to latest changes.

Copy link
Contributor

@valerena valerena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! We'll merge the changes and they will be publicly available after an upcoming release. I'll notify on the existing issue (#74 ) when this gets released. I expect some day next week.

@valerena valerena merged commit ba56ed4 into aws:develop Apr 29, 2024
4 checks passed
@mcieno mcieno deleted the client-context branch April 30, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to invoke a function with custom client context?
2 participants