fix: Impose a 127 character limit on the Lambda function handler when the package type is set to zip #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the package type is set to zip Addresses #1642
normj
requested changes
Sep 19, 2024
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Diagnostics/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
philasmar
approved these changes
Sep 20, 2024
normj
approved these changes
Sep 20, 2024
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR imposes a 127 character limit on the Lambda function handler when the package type is set to
zip.The official AWS docs state a 128 character limit on the Lambda handler. However, there is an open issue where the last character is stripped off when the handler is exactly 128 characters long. Hence, we are enforcing a 127 character limit.
Note: The character limit does not apply when the package type is set to
Image. As part of our integration tests, we have several Lambda functions with the handler names exceeding 127 characters and are deployed sucessfully with an Image based deployment. Example 1 and Example 2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.