Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict the condition for Gradle JVM string #706

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

dkphm
Copy link
Contributor

@dkphm dkphm commented Nov 22, 2024

Issue #, if available:
aws/aws-sam-cli#7730

Description of changes:
Since gradle --version could return this string

Daemon JVM:    /Library/Java/JavaVirtualMachines/amazon-corretto-21.jdk/Contents/Home (no JDK specified, using current Java home)

we should limit the search for JVM on Launcher JVM: and JVM: only.

@dkphm dkphm requested a review from a team as a code owner November 22, 2024 20:31
@dkphm dkphm requested review from hawflau and jysheng123 November 22, 2024 20:31
@github-actions github-actions bot added area/workflow/java_gradle pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 22, 2024
@dkphm dkphm removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Nov 22, 2024
@dkphm dkphm added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit a3b0f90 Nov 22, 2024
131 checks passed
@dkphm dkphm deleted the jvm_string branch November 26, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants