feat: Validate minimum npm version required to use --install-links #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-builders into check_min_npm_version
mndeveci
reviewed
Sep 25, 2023
mndeveci
reviewed
Sep 28, 2023
mildaniel
reviewed
Sep 28, 2023
mndeveci
approved these changes
Sep 28, 2023
| "currently installed npm version does not support " | ||
| "--install-links. Please ensure that the npm " | ||
| "version is at least 8.8.0. Switching to build " | ||
| "in a scratch directory." |
There was a problem hiding this comment.
Link to NPM documentation might be useful
There was a problem hiding this comment.
The closest thing to docs that would indicate the minimum version would be this: https://docs.npmjs.com/cli/v8/using-npm/changelog#v880-2022-04-27
I can add this to the message. Additionally I noticed that I've left the message as "switching to scratch directory", which isn't 100% true for Node.js. I can change this to "switching to building outside of the source directory".
mildaniel
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None.
Description of changes:
--install-linksis a relatively new addition tonpm. We'll need to add a check against the currentnpmversion if build in source is enabled since we need to use that option to properly install local dependencies.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.