feat: nodejs_npm rewrite local deps

[cBiscuitSurprise]

Description of changes:
In line with this design para, I'd like to work on fixing this as it's currently making my life very difficult.

Steps to remove WIP::

• Proof of concept on sample structure
• Expand sample structure and source to include recursive local modules
• Extract common steps from NodejsNpmPackAction and DependencyUtils.package_local_dependency into common function
• Add / Update tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[cBiscuitSurprise]

@elbayaaa @mgrandis How do I go about getting a review of this PR?

[mgrandis]

Thanks for you contribution @cBiscuitSurprise!
I am currently reviewing it.

[mgrandis]

Thanks again for your contribution @cBiscuitSurprise!
I have added a few remarks, I'm open to discuss them.

[hoffa]

Thanks for working on this!

Added a few minor comments, but looking great otherwise.

[hoffa]

Why is the walk necessary?

[mgrandis]

During the building process we update the package.json files to point to the new packed dependencies.
We make backups of the original files.
At the end of the process we walk the dirs to revert the files to their backup so that the files we upload are the original ones. (#187)

[mgrandis]

Quick follow-up:
Referencing local dependencies doesn't work when building in a container.
We are discussing how to handle this situation.

[mgrandis]

@cBiscuitSurprise
Just a little update to ask you about your personal usage of local dependencies.
Are they usually inside the project directory (next to your template) or can they be anywhere on your hard drive?
I know this PR handles both but this question would help for our design on mounting them inside the build container.
Thanks!

[cBiscuitSurprise]

@mgrandis At this point, we've only included our dependencies as git-submodules (and thus they live within the project directory). I hadn't thought about the generic case. I could see some potential there for us, but at this point, it's not our requirement.

[moelasmar]

Thanks @cBiscuitSurprise for your contribution, I will mark this PR as draft till we finalize the local dependencies usage when building in containers

[jfuss]

I chatted with the team about this. I know a lot of effort was put into this PR but we are not going to accept this contribution.

The team has another way we want to tackle local dependencies across many of the runtimes we support with build. The solution will allow us for a wider support than just Node. My understanding of the direction we are wanting to take is build within the source directory. This should solve for more problems we see with build than just local dependencies. I do not have an ETA to share with the community at this time.

Thanks for the contribution and time invested in this PR.

[0cv]

@jfuss any place (issue, pr, etc.) where we can track the progress on the resolution of this issue?

[fabge]

It'd be nice to have some transparency on the current state of this issue. We are having trouble here as well. @jfuss

[jarnohenneman]

Hi @jfuss , is there a workable solution available? or an update maybe

[fabge]

@jfuss we would all appreciate and update on the current development status

[kirilgorbachov]

@jfuss Any update on this one?

[AdrKacz]

@jfuss since you closed the PR to resolve the issue we cannot see any improvement. What is the status how the feature you told about?

[jarnohenneman]

@jfuss apologies for the second ping on this. Any clarification would be much appreciated;

cc; @moelasmar @mgrandis @hoffa

[alphonse92]

No updates?

[SeongrokLee]

I got a solution to resolve it. if you move modules from devDependencies to dependencies, it's works well. But I don't know why doesn't work in case of dev.