feat: Simplify error when decrypting a single EDK #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decryption may attempt to decrypt multipule encrypted data keys (EDK) To return all errors we wrap them in a `CollectionOfErrors`. However, unwrapping these errors can be complicated. To simplify, if there is only a single error, don’t wrap it, just return the single error.
|
This would change the existing error behavior of the library. This is a good idea, but it needs to bake a little more. As is this would be a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decryption may attempt to decrypt multiple encrypted data keys (EDK) To return all errors we wrap them in a
CollectionOfErrors.However, unwrapping these errors can be complicated. To simplify, if there is only a single error,
don’t wrap it, just return the single error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.