Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add aws-cdk-lib/core to codecov #32641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Dec 23, 2024

@github-actions github-actions bot added the p2 label Dec 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2024 10:41
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2024
run: cd packages/aws-cdk && yarn test

- name: Upload results to Codecov
uses: codecov/codecov-action@v4
with:
directory: packages/aws-cdk/coverage
files: packages/aws-cdk/coverage/cobertura-coverage.xml,packages/aws-cdk-lib/coverage/cobertura-coverage.xml
Copy link
Contributor Author

@iliapolo iliapolo Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer pointing to the expected files because I don't trust codecov's search heuristic.

Note that this won't need another change if we decide to add another submodule (or the entire lib).

@@ -8,6 +8,8 @@ module.exports = {
testMatch: [
'<rootDir>/**/test/**/?(*.)+(test).ts',
],
coveragePathIgnorePatterns: ['\\.generated\\.[jt]s$', '<rootDir>/.*/test/', '.warnings.jsii.js$', '/node_modules/'],
Copy link
Contributor Author

@iliapolo iliapolo Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an override of the base config with a small adjustment to ignoring test files. We need this to ignore files inside aws-cdk-lib/core/test

@iliapolo iliapolo marked this pull request as ready for review December 23, 2024 10:47
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2964410
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants