feat(cli): warn of non-existent stacks in cdk destroy

[go-to-k]

Issue # (if applicable)

Closes #32545.
Fixes #27179.

Reason for this change

Once this PR was reverted by other cli-integ test regression.

• revert PR: revert: "feat(cli): warn of non-existent stacks in cdk destroy" #29577
• the test for regression:

  aws-cdk/packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts

  Line 190 in 07ce8ec

  integTest('context in stage propagates to top', withDefaultFixture(async (fixture) => {

But the regression was apparently due to a cause unrelated to that PR. That has been corrected in this PR (see: https://github.com/aws/aws-cdk/blob/v2.173.1/packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts#L286-L291).

Therefore, I submit the same PR again.

Description of changes

This PR for cli is to warn if stacks with wrong cases (=not exist) specified in cdk destroy.

* It does not display the message Are you sure you want to delete: if there is no matching stack.
* Even if the stack does not exist, cdk destroy will not fail, it will just print a warning.

Actual Outputs:

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Nothing.

Description of how you validated changes

Both of unit tests and cli-integ tests.

The changes were already approved in the last PR.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (5735e9e) to head (ad25a96).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32636      +/-   ##
==========================================
+ Coverage   80.54%   80.83%   +0.28%     
==========================================
  Files         106      106              
  Lines        6954     6975      +21     
  Branches     1287     1292       +5     
==========================================
+ Hits         5601     5638      +37     
+ Misses       1175     1158      -17     
- Partials      178      179       +1     

Flag	Coverage Δ
suite.unit	80.83% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.83% <100.00%> (+0.28%)	⬆️

[go-to-k]

Exemption Request:

The change was already approved in the last PR.

Features must contain a change to a README file.

This PR just outputs warnings so I didn't change README.

Features must contain a change to an integration test file and the resulting snapshot.

No snapshot is needed because this PR is for CLI. And I'm waiting for cli-integ-tests to run.

[mrgrain]

See inline comments. We also need tests for the new suggested stacks messages.

[mrgrain]

Exemption Request:

The change was already approved in the last PR.

Features must contain a change to a README file.

This PR just outputs warnings so I didn't change README.

Features must contain a change to an integration test file and the resulting snapshot.

No snapshot is needed because this PR is for CLI. And I'm waiting for cli-integ-tests to run.

Approved exemptions.

[mrgrain]

PS @go-to-k I'll be off on xmas holidays, I've asked the team to do reviews. If there's no movement by the new year feel free to ping me on cdk.dev. 🎄

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32636/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[go-to-k]

@mrgrain

Thanks for your review! I have made all the suggested changes and added tests for the suggested stacks messages. I would love to see a review from you or the team.

This is a sample image:

Happy Xmas!

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ad25a96
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository