Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): add 3 new resource types #32599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Dec 19, 2024

Add 3 new resource types:

Ref: AWS Config now supports 3 new resource types

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 19, 2024 22:31
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (cbacf4d) to head (8fb1a90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32599   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files         107      107           
  Lines        7131     7131           
  Branches     1319     1319           
=======================================
  Hits         5643     5643           
  Misses       1304     1304           
  Partials      184      184           
Flag Coverage Δ
suite.unit 79.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.13% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fb1a90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2024
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared rule.ts with the documentation, and found these configs are also missing:

  • AWS::AppConfig::ExtensionAssociation
  • AWS::Athena::DataCatalog
  • AWS::Athena::WorkGroup
  • AWS::Cognito::IdentityPool
  • AWS::Cognito::UserPool
  • AWS::Cognito::UserPoolClient
  • AWS::Cognito::UserPoolGroup
  • AWS::Config::ConfigurationRecorder
  • AWS::Detective::Graph
  • AWS::DMS::Certificate
  • AWS::DMS::ReplicationInstance
  • AWS::DMS::ReplicationTask
  • AWS::EC2::NetworkInsightsAccessScope
  • AWS::EC2::NetworkInsightsAnalysis
  • AWS::EC2::VPCBlockPublicAccessOptions
  • AWS::EKS::FargateProfile
  • AWS::Evidently::Segment
  • AWS::GroundStation::DataflowEndpointGroup
  • AWS::IAM::OIDCProvider
  • AWS::ImageBuilder::ImageRecipe
  • AWS::Lambda::Alias
  • AWS::M2::Environment
  • AWS::MediaConnect::Gateway
  • AWS::MemoryDB::SubnetGroup
  • AWS::MSK::ClusterPolicy
  • AWS::MSK::VpcConnection
  • AWS::OpenSearchServerless::VpcEndpoint
  • AWS::Redshift::EndpointAccess
  • AWS::Redshift::EndpointAuthorization
  • AWS::SageMaker::EndpointConfig
  • AWS::SageMaker::NotebookInstanceLifecycleConfig
  • AWS::SSM::Document
  • AWS::Transfer::Profile

There is also a typo for AWS::IoTwinMaker::Workspace, which should be AWS::IoTTwinMaker::Workspace

Finally, it seems like AWS::EventSchemas::Registry and AWS::IoTTwinMaker::ComponentType are gone from Supported Resource Types for AWS Config, so it might be worth deprecating it? Unsure what happened to it

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 24, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 24, 2024

@nmussy
Thank you for the review. I'll investigate further.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We gotta start thinking about generating this class from the doc page @nmussy linked or some other source of truth 😂

In the meantime there's no way we need to have a static property for every single valud resource type... the whole point of an enum-like class is that you can use of and define whatever you want.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Dec 25, 2024

@kaizencc
Thanks for your comments.
I agree there could be endless fixes, so I think I'll close this PR.
However, I felt we should fix the typo that @nmussy pointed out, so I've created a separate PR for that. #32655

There is also a typo for AWS::IoTwinMaker::Workspace, which should be AWS::IoTTwinMaker::Workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants