fix: failing integration tests due to not waiting for TAZ cluster to fully failover #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
fix/integration-tests
branch
from
0286913 to
2508e7f
Compare
karenc-bq
force-pushed
the
fix/integration-tests
branch
from
2508e7f to
a1d27eb
Compare
sergiyvamz
reviewed
Apr 1, 2024
| @@ -102,12 +102,22 @@ private TestEnvironment(TestEnvironmentRequest request) { | |||
| } | |||
|
|
|||
| public static TestEnvironment build(TestEnvironmentRequest request) throws IOException { | |||
| DatabaseEngineDeployment deployment = request.getDatabaseEngineDeployment(); | |||
| if (deployment == DatabaseEngineDeployment.AURORA | |||
| || deployment == DatabaseEngineDeployment.RDS | |||
There was a problem hiding this comment.
I'm not sure about RDS. It's not clear whether they need checks for topology.
sergiyvamz
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TAZ takes a longer time to recover after failover.
Tests need to ensure all instances are available by attempting to establish a connection after triggering failover.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.