-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement configuration profiles #436
Open
karenc-bq
wants to merge
1
commit into
main
Choose a base branch
from
configuration_profiles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
236 changes: 236 additions & 0 deletions
236
aws_advanced_python_wrapper/aurora_initial_connection_strategy_plugin.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,236 @@ | ||
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). | ||
# You may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from __future__ import annotations | ||
|
||
import time | ||
from typing import TYPE_CHECKING, Callable, Optional, Set | ||
|
||
from aws_advanced_python_wrapper.utils.log import Logger | ||
|
||
if TYPE_CHECKING: | ||
from aws_advanced_python_wrapper.driver_dialect import DriverDialect | ||
from aws_advanced_python_wrapper.pep249 import Connection | ||
from aws_advanced_python_wrapper.plugin_service import PluginService | ||
from aws_advanced_python_wrapper.host_list_provider import HostListProviderService | ||
from aws_advanced_python_wrapper.utils.rdsutils import RdsUtils | ||
|
||
from aws_advanced_python_wrapper.errors import AwsWrapperError | ||
from aws_advanced_python_wrapper.host_availability import HostAvailability | ||
from aws_advanced_python_wrapper.hostinfo import HostInfo, HostRole | ||
from aws_advanced_python_wrapper.plugin import Plugin, PluginFactory | ||
from aws_advanced_python_wrapper.utils.messages import Messages | ||
from aws_advanced_python_wrapper.utils.properties import (Properties, | ||
WrapperProperties) | ||
from aws_advanced_python_wrapper.utils.rds_url_type import RdsUrlType | ||
|
||
logger = Logger(__name__) | ||
|
||
|
||
class AuroraInitialConnectionStrategyPlugin(Plugin): | ||
_plugin_service: PluginService | ||
_host_list_provider_service: HostListProviderService | ||
_rds_utils: RdsUtils | ||
|
||
@property | ||
def subscribed_methods(self) -> Set[str]: | ||
return {"init_host_provider", "connect", "force_connect"} | ||
|
||
def __init__(self, plugin_service: PluginService, properties: Properties): | ||
self._plugin_service = plugin_service | ||
|
||
def init_host_provider(self, props: Properties, host_list_provider_service: HostListProviderService, init_host_provider_func: Callable): | ||
self._host_list_provider_service = host_list_provider_service | ||
if host_list_provider_service.is_static_host_list_provider(): | ||
msg = Messages.get("AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider") | ||
logger.warning(msg) | ||
raise AwsWrapperError(msg) | ||
init_host_provider_func() | ||
|
||
def connect(self, target_driver_func: Callable, driver_dialect: DriverDialect, host_info: HostInfo, props: Properties, | ||
is_initial_connection: bool, connect_func: Callable) -> Connection: | ||
return self._connect_internal(host_info, props, is_initial_connection, connect_func) | ||
|
||
def force_connect(self, target_driver_func: Callable, driver_dialect: DriverDialect, host_info: HostInfo, props: Properties, | ||
is_initial_connection: bool, force_connect_func: Callable) -> Connection: | ||
return self._connect_internal(host_info, props, is_initial_connection, force_connect_func) | ||
|
||
def _connect_internal(self, host_info: HostInfo, props: Properties, is_initial_connection: bool, connect_func: Callable) -> Connection: | ||
url_type: RdsUrlType = self._rds_utils.identify_rds_type(host_info.host) | ||
if not url_type.is_rds_cluster: | ||
return connect_func() | ||
|
||
if url_type == RdsUrlType.RDS_WRITER_CLUSTER: | ||
writer_candidate_conn = self._get_verified_writer_connection(props, is_initial_connection, connect_func) | ||
if writer_candidate_conn is None: | ||
return connect_func() | ||
return writer_candidate_conn | ||
|
||
if url_type == RdsUrlType.RDS_READER_CLUSTER: | ||
reader_candidate_conn = self._get_verified_reader_connection(props, is_initial_connection, connect_func) | ||
if reader_candidate_conn is None: | ||
return connect_func() | ||
return reader_candidate_conn | ||
|
||
# Continue with a normal workflow. | ||
return connect_func() | ||
|
||
def _get_verified_writer_connection(self, props: Properties, is_initial_connection: bool, connect_func: Callable) -> Optional[Connection]: | ||
retry_delay_ms: int = WrapperProperties.OPEN_CONNECTION_RETRY_TIMEOUT_MS.get_int(props) | ||
end_time_nano = self._get_time() + retry_delay_ms * 1_000_000 | ||
|
||
writer_candidate_conn: Optional[Connection] | ||
writer_candidate: Optional[HostInfo] | ||
|
||
while self._get_time() < end_time_nano: | ||
writer_candidate_conn = None | ||
writer_candidate = None | ||
|
||
try: | ||
writer_candidate = self._get_writer() | ||
if writer_candidate_conn is None or self._rds_utils.is_rds_cluster_dns(writer_candidate.host): | ||
writer_candidate_conn = connect_func() | ||
self._plugin_service.force_refresh_host_list(writer_candidate_conn) | ||
writer_candidate = self._plugin_service.identify_connection(writer_candidate_conn) | ||
|
||
if writer_candidate is not None and writer_candidate.role != HostRole.WRITER: | ||
# Shouldn't be here. But let's try again. | ||
self._close_connection(writer_candidate_conn) | ||
self._delay(retry_delay_ms) | ||
continue | ||
|
||
if is_initial_connection: | ||
self._host_list_provider_service.initial_connection_host_info = writer_candidate | ||
|
||
return writer_candidate_conn | ||
|
||
writer_candidate_conn = self._plugin_service.connect(writer_candidate, props) | ||
|
||
if self._plugin_service.get_host_role(writer_candidate_conn) != HostRole.WRITER: | ||
self._plugin_service.force_refresh_host_list(writer_candidate_conn) | ||
self._close_connection(writer_candidate_conn) | ||
self._delay(retry_delay_ms) | ||
continue | ||
|
||
if is_initial_connection: | ||
self._host_list_provider_service.initial_connection_host_info = writer_candidate | ||
return writer_candidate_conn | ||
|
||
except Exception as e: | ||
if writer_candidate is not None: | ||
self._plugin_service.set_availability(writer_candidate.as_aliases(), HostAvailability.UNAVAILABLE) | ||
self._close_connection(writer_candidate_conn) | ||
raise e | ||
|
||
return None | ||
|
||
def _get_verified_reader_connection(self, props: Properties, is_initial_connection: bool, connect_func: Callable) -> Optional[Connection]: | ||
retry_delay_ms: int = WrapperProperties.OPEN_CONNECTION_RETRY_INTERVAL_MS.get_int(props) | ||
end_time_nano = self._get_time() + WrapperProperties.OPEN_CONNECTION_RETRY_TIMEOUT_MS.get_int(props) * 1_000_000 | ||
|
||
reader_candidate_conn: Optional[Connection] | ||
reader_candidate: Optional[HostInfo] | ||
|
||
while self._get_time() < end_time_nano: | ||
reader_candidate_conn = None | ||
reader_candidate = None | ||
|
||
try: | ||
reader_candidate = self._get_reader(props) | ||
if reader_candidate is None or self._rds_utils.is_rds_cluster_dns(reader_candidate.host): | ||
# Reader not found, topology may be outdated | ||
reader_candidate_conn = connect_func() | ||
self._plugin_service.force_refresh_host_list(reader_candidate_conn) | ||
reader_candidate = self._plugin_service.identify_connection(reader_candidate_conn) | ||
|
||
if reader_candidate is not None and reader_candidate.role != HostRole.READER: | ||
if self._has_no_readers(): | ||
# Cluster has no readers. Simulate Aurora reader cluster endpoint logic | ||
if is_initial_connection and reader_candidate.host is not None: | ||
self._host_list_provider_service.initial_connection_host_info = reader_candidate | ||
return reader_candidate_conn | ||
self._close_connection(reader_candidate_conn) | ||
self._delay(retry_delay_ms) | ||
continue | ||
|
||
if reader_candidate is not None and is_initial_connection: | ||
self._host_list_provider_service.initial_connection_host_info = reader_candidate | ||
return reader_candidate_conn | ||
|
||
reader_candidate_conn = self._plugin_service.connect(reader_candidate, props) | ||
if self._plugin_service.get_host_role(reader_candidate_conn) != HostRole.READER: | ||
# If the new connection resolves to a writer instance, this means the topology is outdated. | ||
# Force refresh to update the topology. | ||
self._plugin_service.force_refresh_host_list(reader_candidate_conn) | ||
|
||
if self._has_no_readers(): | ||
# Cluster has no readers. Simulate Aurora reader cluster endpoint logic | ||
if is_initial_connection: | ||
self._host_list_provider_service.initial_connection_host_info = reader_candidate | ||
return reader_candidate_conn | ||
|
||
self._close_connection(reader_candidate_conn) | ||
self._delay(retry_delay_ms) | ||
continue | ||
|
||
# Reader connection is valid and verified. | ||
if is_initial_connection: | ||
self._host_list_provider_service.initial_connection_host_info = reader_candidate | ||
return reader_candidate_conn | ||
|
||
except Exception: | ||
self._close_connection(reader_candidate_conn) | ||
if reader_candidate is not None: | ||
self._plugin_service.set_availability(reader_candidate.as_aliases(), HostAvailability.AVAILABLE) | ||
|
||
return None | ||
|
||
def _close_connection(self, connection: Optional[Connection]): | ||
if connection is not None: | ||
try: | ||
connection.close() | ||
except Exception: | ||
# ignore | ||
pass | ||
|
||
def _delay(self, delay_ms: int): | ||
time.sleep(delay_ms / 1000) | ||
|
||
def _get_writer(self) -> Optional[HostInfo]: | ||
return next(host for host in self._plugin_service.hosts if host.role == HostRole.WRITER) | ||
|
||
def _get_reader(self, props: Properties) -> Optional[HostInfo]: | ||
strategy: Optional[str] = WrapperProperties.READER_HOST_SELECTOR_STRATEGY.get(props) | ||
if strategy is not None and self._plugin_service.accepts_strategy(HostRole.READER, strategy): | ||
try: | ||
return self._plugin_service.get_host_info_by_strategy(HostRole.READER, strategy) | ||
except Exception: | ||
# Host isn't found | ||
return None | ||
|
||
raise AwsWrapperError(Messages.get_formatted("AuroraInitialConnectionStrategyPlugin.UnsupportedStrategy", strategy)) | ||
|
||
def _has_no_readers(self) -> bool: | ||
if len(self._plugin_service.hosts) == 0: | ||
# Topology inconclusive. | ||
return False | ||
return next(host_info for host_info in self._plugin_service.hosts if host_info.role == HostRole.READER) is None | ||
|
||
def _get_time(self): | ||
return time.perf_counter_ns() | ||
|
||
|
||
class AuroraInitialConnectionStrategyPluginFactory(PluginFactory): | ||
def get_instance(self, plugin_service: PluginService, props: Properties) -> Plugin: | ||
return AuroraInitialConnectionStrategyPlugin(plugin_service, props) |
44 changes: 0 additions & 44 deletions
44
aws_advanced_python_wrapper/driver_configuration_profiles.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.