refactor: use session state service impl to change readOnly state #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
from
9a78e0d to
763f862
Compare
karenc-bq
reviewed
Nov 16, 2024
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
2 times, most recently
from
4b3a16d to
9f458e1
Compare
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
4 times, most recently
from
a3d796a to
f30dc78
Compare
sophia-bq
reviewed
Nov 22, 2024
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
3 times, most recently
from
5f9448f to
7f2589c
Compare
crystall-bitquill
added
ready for review
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
3 times, most recently
from
75aab2c to
4ca0c6d
Compare
sergiyvamz
reviewed
Dec 5, 2024
sergiyvamz
reviewed
Dec 5, 2024
sergiyvamz
reviewed
Dec 5, 2024
karenc-bq
reviewed
Dec 5, 2024
crystall-bitquill
force-pushed
the
refactor/update-read-only
branch
from
4ca0c6d to
808e856
Compare
karenc-bq
force-pushed
the
refactor/update-read-only
branch
from
808e856 to
430cad0
Compare
karenc-bq
force-pushed
the
refactor/update-read-only
branch
from
9a825ce to
1afb184
Compare
karenc-bq
force-pushed
the
refactor/update-read-only
branch
from
da0dc24 to
023ba38
Compare
joyc-bq
reviewed
Dec 24, 2024
| @@ -15,6 +15,7 @@ | |||
| */ | |||
|
|
|||
| import { HostInfo } from "./host_info"; | |||
| import { SessionState } from "./session_state"; | |||
There was a problem hiding this comment.
nit: is this an unneeded import?
joyc-bq
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor: use session state service impl to change readOnly state
Description
This PR removes the
updateSessionStateReadOnlyandresetStatemethods from the MySQL and PG client classes to prevent them from being publicly accessible. The readOnly status has been moved from the AWS client class to the ClientWrapper interface by adding a session state to the client wrapper.Currently only the readOnly state has been moved, the other session state fields are to be altered in a future PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.