Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KOps Integration Test #3140

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Fix KOps Integration Test #3140

merged 2 commits into from
Dec 7, 2024

Conversation

dshehbaj
Copy link
Member

@dshehbaj dshehbaj commented Dec 7, 2024 •
edited
Loading

What type of PR is this?

  • Test fix

Which issue does this PR fix?:

What does this PR do / Why do we need it?:

  • Our K-Ops integration test has been failing for 7+ months in GitHub actions. This PR fixes it.

Changes made:

  • Increased control plane node count for KOps test cluster to mitigate intermittent network issues with the API Server encountered during the test.
  • Increased flake attempt/retry count from 2 to 8 to make sure that any test failures are not random.
  • Added debug statements and modified Ginkgo flags to help with better debugging output if test fails in future. This test is very large with lots of output therefore debugging can be very challenging.

Testing done on this change:

@dshehbaj dshehbaj changed the title Shehbaj/fix kops integration Fix KOps Integration Test Dec 7, 2024
@dshehbaj dshehbaj force-pushed the shehbaj/fix-kops-integration branch from 4683668 to b0dbc8e Compare December 7, 2024 01:51
@dshehbaj dshehbaj force-pushed the shehbaj/fix-kops-integration branch from b0dbc8e to 29bdbc7 Compare December 7, 2024 01:53
@dshehbaj dshehbaj marked this pull request as ready for review December 7, 2024 01:55
@dshehbaj dshehbaj requested a review from a team as a code owner December 7, 2024 01:55
@jayanthvn jayanthvn merged commit fb6d231 into master Dec 7, 2024
4 checks passed
orsenthil pushed a commit that referenced this pull request Dec 10, 2024
@dshehbaj @orsenthil
Fix KOps Integration Test (#3140)
bfd0705 
* scripts lib integration: add more logging steps

* scripts lib cluster: increase kops control plane node size
orsenthil pushed a commit that referenced this pull request Dec 10, 2024
@dshehbaj @orsenthil
Fix KOps Integration Test (#3140)
c4642c7 
* scripts lib integration: add more logging steps

* scripts lib cluster: increase kops control plane node size
@dshehbaj dshehbaj mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayanthvn jayanthvn jayanthvn approved these changes

@orsenthil orsenthil Awaiting requested review from orsenthil

@jaydeokar jaydeokar Awaiting requested review from jaydeokar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshehbaj @jayanthvn