[processor/awsentity] Add awsentity processor into EMF pipeline #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhihonl
commented
Dec 23, 2024
| @@ -110,6 +111,10 @@ func newAwsEntityProcessor(config *Config, logger *zap.Logger) *awsEntityProcess | |||
| } | |||
| } | |||
|
|
|||
| func (p *awsEntityProcessor) processLogs(_ context.Context, ld plog.Logs) (plog.Logs, error) { | |||
There was a problem hiding this comment.
This function is a no-op for now since this PR is focused on adding awsentity processor to the pipeline. Will be expanded in later PRs to add entity attributes for log pipelines
zhihonl
commented
Dec 23, 2024
| @@ -26,7 +26,9 @@ func NewFactory() processor.Factory { | |||
| return processor.NewFactory( | |||
| TypeStr, | |||
| createDefaultConfig, | |||
| processor.WithMetrics(createMetricsProcessor, stability)) | |||
| processor.WithMetrics(createMetricsProcessor, stability), | |||
| processor.WithLogs(createLogsProcessor, stability), | |||
There was a problem hiding this comment.
Added these in factory code so awsentity can be added as a log type processor but it doesn't really do anything now
zhihonl
changed the title
zhihonl
changed the title
zhihonl
changed the title
lisguo
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We want the ability to send entities for customers forwarding EMF logs using the EMF forwarding plugin: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Generation_CloudWatch_Agent.html
To do this, we should add the awsentity processor which contains logic providing entity attributes to cloudwatch exporters.
Description of changes
awsentityprocessor to EMF log pipeline.Note that this change does not change the telemetry yet, it just sets up the pipeline for future modifications.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit test.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint