Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JMX E2E Tests in Testing Workflow #1463

Open
wants to merge 83 commits into
base: main
Choose a base branch
from
Open

Implement JMX E2E Tests in Testing Workflow #1463

wants to merge 83 commits into from

Conversation

musa-asad
Copy link
Contributor

@musa-asad musa-asad commented Dec 9, 2024

Description of the issue

The CloudWatch Agent now supports JMX metrics on EKS. We need to add testing to verify the behavior for JMX metrics collection in EKS environments.

Description of changes

Co-PR: aws/amazon-cloudwatch-agent-test#443.

  • Implement EKSE2EJVMTomcatTest, EKSE2EKafkaTest, and EKSE2EJMXContainerInsightsTest jobs in order to run testing for those configurations.
  • Passed in matrix.arrays.nodes as a value for Terraform to use.
  • Add "cwagent-monitoring-config-e2e-eks-" to ClustersToClean string array to clean those clusters.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Workflow Status
View Workflow Run #12452251638

Workflow Status
View Workflow Run #12451922519

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@musa-asad musa-asad changed the title JMX E2E Tests Implement JMX E2E Tests in Testing Workflow Dec 17, 2024
@musa-asad musa-asad marked this pull request as ready for review December 17, 2024 09:00
@musa-asad musa-asad requested a review from a team as a code owner December 17, 2024 09:00
varunch77
varunch77 previously approved these changes Dec 17, 2024
Copy link
Member

@varunch77 varunch77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/nonblocking comment: the names for the two test files could be made more clear/better reflect their purpose

dricross
dricross previously approved these changes Dec 17, 2024
TravisStark
TravisStark previously approved these changes Dec 18, 2024
@musa-asad musa-asad dismissed stale reviews from TravisStark, varunch77, and dricross via 2c74c4f December 18, 2024 23:24
@musa-asad musa-asad requested review from TravisStark, varunch77 and dricross and removed request for jefchien and okankoAMZ December 20, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants