Fix issues with PerformanceReport Page (commit data, hiding missing data) #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
force-pushed
the
feature/performance-report
branch
from
d48f203 to
0712349
Compare
…ata) and increase Axios timeout
TravisStark
force-pushed
the
feature/performance-report
branch
from
0712349 to
465a163
Compare
okankoAMZ
reviewed
Dec 11, 2024
| @@ -5,7 +5,7 @@ import axios from 'axios'; | |||
|
|
|||
| export const AxiosConfig = axios.create({ | |||
| baseURL: process.env.REACT_APP_LAMBDA_URL, | |||
| timeout: 3000, | |||
| timeout: 5000, | |||
There was a problem hiding this comment.
what is this based on can we document it? can we also document that this is in milli seconds
There was a problem hiding this comment.
The trends page often runs into a timeout when collecting commit data.
Will update this to add retry/show an error page as well.
okankoAMZ
reviewed
Dec 11, 2024
| // commit_title: `${commit_info?.title} (#${commit_info?.number})`, | ||
| // commit_url: commit_info?.html_url, | ||
| commit_title: `${commit_info?.title} (#${commit_info?.number})`, | ||
| commit_url: commit_info?.html_url, |
There was a problem hiding this comment.
can we add default fallbacks here to make sure it doesn't break
|
|
||
| setState((prev: any) => ({ | ||
| ...prev, | ||
| version: service_info.tag_name, | ||
| ami_id: ami_id, | ||
| collection_period: collection_period, | ||
| use_cases: use_cases, | ||
| // commit_title: `${commit_info?.title} (#${commit_info?.number})`, | ||
| // commit_url: commit_info?.html_url, | ||
| commit_title: `${commit_info?.title} (#${commit_info?.number})`, |
There was a problem hiding this comment.
can we add default fallbacks here to make sure it doesn't break
| .at(0); | ||
| const commit_history = selected_hash_information?.commit.message.replace(/\n\r*\n*/g, '<br />'); | ||
| const commited_by = `Committed by ${selected_hash_information?.author.login} on ${selected_hash_information?.author.date}`; | ||
| const commited_by = `Committed by ${selected_hash_information?.author.login} on ${selected_hash_information?.commit?.author?.date}`; |
There was a problem hiding this comment.
can we add default fallbacks here to make sure it doesn't break
| <StyledTableCell>{Number(use_case.data?.[data_rate]?.net_bytes_sent).toFixed(2)}</StyledTableCell> | ||
| <StyledTableCell>{Number(use_case.data?.[data_rate]?.net_packets_sent).toFixed(2)}</StyledTableCell> | ||
| </StyledTableRow> | ||
| ) : null; |
There was a problem hiding this comment.
is it better to return null than <> component ?
|
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Fixes issues with PerformanceReport Page
Description of changes
How does this change address the problem?
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint