Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-process nvidia gpu memory usage. #1235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ash-shipit
Copy link

@ash-shipit ash-shipit commented Jul 7, 2024

Description of the issue

  • Currently, users cannot see gpu memory usage at a per-process level. They can only see gpu memory usage across the entire gpu. nvidia-smi does emit per-process gpu memory usage, but the cloudwatch agent does not parse that information.

Description of changes

  • Extend current nvidia smi metrics to include per process gpu memory usage.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

  • Added unit tests.
  • Tested in personal account (build tested: linux/amd64/amazon-cloudwatch-agent.deb). See screenshots below. CloudWatch agent config used: https://pastebin.com/66jUu09T

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Screenshot 2024-07-07 at 1 06 23 AM

Screenshot 2024-07-07 at 1 05 54 AM

@ash-shipit ash-shipit requested a review from a team as a code owner July 7, 2024 05:08
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant