既存の ACM 証明書を指定してカスタムドメインを利用可能にする #627
Open
+82
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
既存の ACM 証明書を指定してカスタムドメインを利用可能にする
Issue #, if available:
Description of changes:
同一アカウント内に存在する既存の ACM 証明書を CloudFront ディストリビューションで使用できるようします。これにより、別の AWS アカウントでホストテッドゾーンが管理されている場合でもカスタムドメインを使用することができます。
context に
certificateArnを追加し、既存の証明書 ARN を受け入れるよう変更しました。hostedZoneIdが指定された場合はこれまで通り新しい証明書や DNS レコードを作成します。certificateArnとhostedZoneIdは同時に指定できないため、hostName,domainName,hostedZoneId,certificateArnの組み合わせに関するバリデーションチェックも追加しました。By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.