Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure each invocation of a pipeline has its own Activity #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snake-scaly
Copy link

This fixes #145.

AWSTracingPipelineHandler is made concurrency-safe by storing the current Activity in an AsyncLocal field.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@snake-scaly snake-scaly requested a review from a team as a code owner December 10, 2024 12:13
@snake-scaly
Copy link
Author

The test failure seems unrelated. I can see another PR failing with exactly the same error.

@AsakerMohd
Copy link
Collaborator

The test failure seems unrelated. I can see another PR failing with exactly the same error.

Yeah it should be unrelated. I restarted the build.

@snake-scaly snake-scaly force-pushed the fix/concurrent-spans branch 3 times, most recently from 9febaec to 1db7391 Compare December 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spans are lost if the same client is used for multiple requests concurrently
2 participants