Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws sdk go v2- rk #163

Open
wants to merge 2 commits into
base: aws-sdk-go-v2
Choose a base branch
from

Conversation

rkurduka
Copy link

Issue #, if available:

Description of changes:

Require changes to migrate controller from AWS-SDK-GO-V1 to AWS-SDK-GO-V2

  1. AWS-SDK-GO-V2 require "aws config" from "github.com/aws/aws-sdk-go-v2/aws", so added new field as config in "ManageFor" method for "AWSResourceManagerFactory" interface.

  2. method to getsdkv2config in "reconciler.go" and "adoption_reconciler.go" and use awsconfig while creating instance for "ManageFor"

  3. Ran the "make mocks" - to generate mock interfaces for testcases

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler October 11, 2024 17:31
Copy link

ack-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ack-prow bot commented Oct 11, 2024

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution bf29cd7 link false /test verify-attribution
ecr-controller-test bf29cd7 link true /test ecr-controller-test
s3-controller-test bf29cd7 link true /test s3-controller-test
iam-controller-test bf29cd7 link true /test iam-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant