Add CidrCollection support to route53 controller

[gvdhart]

Issue #, if available: NA

Description of changes:
Adding CidrCollection compatibility to the route53 controller

• Create and Delete CidrCollections
• Put and Delete CidrLocations and CidrBlocks in a CidrCollection
  All using a single k8s resource for each AWS cidr Collection.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gvdhart
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @gvdhart. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[a-hilaly]

Thank you @gvdhart !! i did a quick review to the API and the comparison functions, please let me know what you think.

[a-hilaly]

Do we want this to be a [][]CIDRBlocks ? Also wondering if we really need the Action field.

[gvdhart]

I agree, we technically do not need the Action field in the resource definition, however I used the generator to create this field, let me check if I can simplify this part as indeed it would be nicer to have a cidrBlock representation here.

[gvdhart]

After investigation I do not think that a CIdrBlock type is the best here, there is just a string in it that contains all cidrblocks, not a list of strings. Furthermore I would have to complicate things in the genrator file to get that working. I would prefer to leave it like this.
Sure the Action field is not required as I set it in the code, but i could not manage to have it removed with the generator.

[gvdhart]

/retest

[gvdhart]

@a-hilaly I think it is good to go!
However I have one test that fails 'route53-verify-attribution' but I don't know what this one does and it never failed before.

[gvdhart]

/retest

[ack-prow]

@gvdhart: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
route53-verify-attribution	2d9f8d3	link	false	/test route53-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.