Switch to using json string capabilities #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/jsonstringing
branch
from
8824f20 to
f942f2a
Compare
kddejong
force-pushed
the
fix/jsonstringing
branch
from
f942f2a to
f927bc2
Compare
kddejong
commented
Jan 12, 2021
| @@ -12,7 +12,7 @@ package resource | |||
| // {{model_name}} is autogenerated from the json schema | |||
| type {{model_name}} struct { | |||
| {% for name, type in properties.items() %} | |||
| {{ name|uppercase_first_letter }} {{ type|translate_type }} `json:",omitempty"` | |||
| {{ name|uppercase_first_letter }} {{ type|translate_type }} `json:",omitempty{% if type|translate_type in ["*bool", "*int", "*float64"] %},string{% endif %}"` | |||
There was a problem hiding this comment.
Started != "*string" but that will add string to nested structs. Switched to this instead. I think this list is extensive.
We cannot include this with strings or you will end up with nested quotes. "\"string\""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.