Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 - Rework Cfn Init validation rules #3262

Merged
merged 2 commits into from
May 23, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • V1 - Rework Cfn Init validation rules
  • Add typing to match function

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.62%. Comparing base (1d86f9d) to head (c686910).

Files Patch % Lines
.../cfnlint/rules/functions/RelationshipConditions.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3262      +/-   ##
==========================================
- Coverage   92.72%   92.62%   -0.11%     
==========================================
  Files         308      308              
  Lines       10587    10624      +37     
  Branches     2245     2246       +1     
==========================================
+ Hits         9817     9840      +23     
- Misses        435      444       +9     
- Partials      335      340       +5     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit a8ce012 into aws-cloudformation:main May 23, 2024
21 of 22 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/23 branch May 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant