test(e2e): add storage-browser offline tests #6206
Conversation
|
| When I type my "email" with status "CONFIRMED" | ||
| Then I type my password | ||
| Then I click the "Sign in" button |
There was a problem hiding this comment.
Nit: this is entirely non-blocking of this PR, but would it fit for there to be step specifically for signing into the storage browser which would just be equivalent to these three steps? Having every test start with 3 - 4 steps to get to the right starting place can really cause these files to get large and less straightforward to parse
There was a problem hiding this comment.
Moved these 3 steps to background (beforeEach) on all the feature files.
And I type my "email" with status "CONFIRMED"
And I type my password
And I click the "Sign in" button
The other option would be to directly define a step "I login into storage-browser" in cypress as code
| @@ -38,4 +31,3 @@ Feature: Drag and drop files within Storage Browser | |||
| Then I press the "{esc}" key | |||
| When I drag and drop a file into the storage browser with file name "test.txt" | |||
| Then I see "test.txt" | |||
|
|
|||
There was a problem hiding this comment.
Should there be an EOF newline?
| And I type my "email" with status "CONFIRMED" | ||
| And I type my password | ||
| And I click the "Sign in" button |
There was a problem hiding this comment.
Nit: would it make sense to add the line And I click the first button containing "public"? It's also repeated at the start of every scenario, but I could see it going either way as to whether it could be considered "putting the system in a known state before the user starts interacting with it" as Givens are supposed to be used.
There was a problem hiding this comment.
If we took this route, it would apply to the other feature files included in these changes as well
Description of changes
Add offline e2e tests for action menu items
Description of how you validated changes
Tested in cypress locally
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.