Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): Fixed AWSCloudWatch output infinite number of errors when access denied #13804

Open
wants to merge 5 commits into
base: v5-stable
Choose a base branch
from
Open

fix(logging): Fixed AWSCloudWatch output infinite number of errors when access denied #13804

wants to merge 5 commits into from

Conversation

yuhengshs
Copy link
Contributor

@yuhengshs yuhengshs commented Sep 12, 2024 •
edited
Loading

Description of changes

Set the log output limits to maximum 5 times. Once the retries reached limit, it will reset the retry counter to zero and restart the cycle again.

Issue #, if available

#9575

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jimblanc
jimblanc reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could we also add some unit tests to AWSCloudWatchProvider-test.ts?

packages/core/src/Providers/AWSCloudWatchProvider.ts Outdated Show resolved Hide resolved
@yuhengshs yuhengshs force-pushed the yuhengsh-awscloudwatchprovider branch 2 times, most recently from 9afcb99 to 3ba6b64 Compare September 16, 2024 21:14
@yuhengshs yuhengshs force-pushed the yuhengsh-awscloudwatchprovider branch from 1e997a9 to 2a28c2e Compare September 17, 2024 15:29
@yuhengshs
Copy link
Contributor Author

Looks good, could we also add some unit tests to AWSCloudWatchProvider-test.ts?

Thanks Jim! Added unit tests for the new changes. Will make this ready for review!

@yuhengshs yuhengshs marked this pull request as ready for review September 17, 2024 15:52
@yuhengshs yuhengshs requested review from a team as code owners September 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblanc jimblanc jimblanc left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhengshs @jimblanc