-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow CustomType and RefType in arguments #387
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 45074a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR is currently in draft because the unit test check failed. I'm investigating the issue and will update the PR once resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's actually establish a feature branch and/or a branch for tagged releases instead of merging to main
for now. I think this would leave main
in a broken state (or at least an "odd" state) if the type changes are released ahead of the implementation changes. I.e., we'd be exposing a builder type that either fails or does nothing. And, I think in this case it would actually fail if these builder methods were called. Is that correct?
Good point, @svidgen. I’ll set up a feature branch to keep main stable and ensure all builder methods align with the type changes. Appreciate the insight! |
Co-authored-by: aws-amplify-bot <[email protected]>
Description of changes: This PR allows the use of CustomType and RefType in arguments for custom operations in the @aws-amplify/data-schema package. Specifically:
These changes enhance the flexibility of schema definitions by allowing more complex argument structures in custom operations.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.