Update nodejs express serverless function template #13194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
requested changes
Sep 11, 2023
| @@ -5,8 +5,7 @@ | |||
| "main": "index.js", | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "aws-serverless-express": "^3.3.5", | |||
| "body-parser": "^1.17.1", | |||
| "@vendia/serverless-express": "^4.10.4", | |||
There was a problem hiding this comment.
why are we using 3rd party dependency for this?
There was a problem hiding this comment.
aws-serverless-express is being deprecated and rebranded to vendia
on the npm: On 11/30, the AWS Serverless Express library is moving to Vendia and will be rebranded to serverless-express. Similarly, the aws-serverless-express NPM package will be deprecated in favor of a new serverless-express package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
update the aws-express-serverless to vendia/serverless-express in function nodejs templates Serverless ExpressJS function (Integration with API Gateway)
Adds e2e test to call API gateway
vendia repo
this was modified according to example
Issue #, if available
#10812
Description of how you validated changes
added tests to invoke the API and manually tested the API.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.