Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mis build to the data factory #2223

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stocaaro
Copy link
Member

@stocaaro stocaaro commented Nov 12, 2024

Problem

Users would like to use the Gen2 data client interface to access their APIs from application functions (lambda's).

Our docs offer instructions on this experience, which stop short of indicating how the customer should provide the model introspection schema needed to make the whole experience work.

Change

  1. Build the Model Introspection Schema (MIS) in the data factory
  2. Construct an S3 bucket with the MIS as an object
  3. Grant get permission to the MIS to any function that is granted resource permissions to the data schema
  4. Add the bucket name and object key for the MIS to SSM (where it will be read

In isolation, this change builds the MIS to S3 and grants permission, but the user story to consume this in a function would be complicated without the data config change that makes the in function configuration process trivial.

Corresponding docs PR, if applicable:
aws-amplify/docs#8096

Validation

  • Unit tests added
  • Manually tested in an example application
  • Add E2E testing

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: d381f73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend Patch
@aws-amplify/backend-data Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stocaaro stocaaro marked this pull request as ready for review November 13, 2024 23:12
@stocaaro stocaaro requested review from a team as code owners November 13, 2024 23:12
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.changeset/rare-kiwis-live.md Outdated Show resolved Hide resolved
@stocaaro stocaaro force-pushed the stocaaro/client-schema/mis-build branch from 18e5bc7 to d381f73 Compare November 14, 2024 15:37
@stocaaro stocaaro marked this pull request as draft November 15, 2024 22:08
@stocaaro
Copy link
Member Author

Reverting to draft. This change has been merged into #2224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants