Recommend using GitHub OIDC role assumption over hardcoded access keys #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicheey
reviewed
Dec 12, 2024
| @@ -27,8 +27,8 @@ jobs: | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| - uses: aws-actions/configure-aws-credentials@v2 | |||
| with: | |||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | |||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | |||
| role-to-assume: ${{ secrets.ASSUME_ROLE_ARN }} | |||
There was a problem hiding this comment.
Is there any additional information about assuming a role credential that would be helpful to add here for customers?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Description
Checklist
npm run allBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.