Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add batch support #59

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

seebees
Copy link
Collaborator

@seebees seebees commented Nov 25, 2020

CodeBuild supports batches.
A single buildspec can kick off several batches.

This adds support for both running as a command line as well as running as a GitHub action.

Additional

  • Update the Readme with the correct npx command
  • Add wallaby conf for faster testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

CodeBuild supports batches.
A single buildspec can kick off several batches.

This adds support for both running as a command line as well as running as a GitHub action.

Additional
* Update the Readme with the correct `npx` command
* Add wallaby conf for faster testing
@seebees seebees requested a review from mattsb42-aws November 25, 2020 00:15
By passing the is id instead of the arn
I would stream each build twice.
The `currentBuildSummary` only has the arn
so I can only identify builds by arn.
@robin-aws
Copy link
Contributor

Does this echo the build logs from each of the builds in the batch?

@@ -183,7 +183,7 @@ In order to use this tool,
you must first `git checkout` the commit that you want to test.

```
npx @aws-actions/codebuild-run-build -p ProjectName -r remoteName
npx https://github.com/aws-actions/aws-codebuild-run-build.git -p ProjectName -r remoteName

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional change? If so, why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the package has not been published to npm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable. This can be shortened however:

Suggested change
npx https://github.com/aws-actions/aws-codebuild-run-build.git -p ProjectName -r remoteName
npx aws-actions/aws-codebuild-run-build -p ProjectName -r remoteName

@seebees
Copy link
Collaborator Author

seebees commented Aug 10, 2021

@robin-aws Yes, it will echo each build in the batch.
It would be good to get some feedback on that part as for large batches this can get very long. If I wait a large amount e.g. 30 sec or so then this can take ignorantly long. If I wait a small amount then I may get throttled. Ideally there would be a simple retry/back off.

@KyleThen
Copy link

KyleThen commented Jan 7, 2022

Is there any update to when this might be merged and released?

@aajtodd
Copy link

aajtodd commented Sep 30, 2022

Any update here?

@bertvanbrakel
Copy link

So, any movement on this one? The main reason I want to use AWS codebuild is for parallel batch testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants