feat: add possibility to add more than one container in container-name #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentur-zabbeJ-8basdy
approved these changes
Feb 7, 2023
|
Just want to say, can't wait for this feature to be merged in, it's going to be particularly helpful! |
|
Hi @felipem1210, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:
|
felipem1210
force-pushed
the
feat/multiple-container-names
branch
from
9078387 to
dc8a621
Compare
|
@amazreech I was totally unaware that you had reviewed this PR, I just have resolved the conflicts, glad to know that there is people still maintaining this project |
felipem1210
force-pushed
the
feat/multiple-container-names
branch
from
dc8a621 to
0f5243f
Compare
|
@amazreech Hi 👋 . Is there an update on this? |
felipem1210
force-pushed
the
feat/multiple-container-names
branch
from
0f5243f to
5ca03ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #228
Description of changes:
In this PR I'm adding the possibilty to pass more than one container inside container-name input. The container names can be passed comma separated. The same image and environment variables will be applied to all the containers
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.