Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed errornous kernel parameters overwrite to fix CentOS 6.6 install #3342

Merged

Conversation

hpaluch-pil
Copy link
Contributor

Fixes Issue #3341 caused by db64d32

The kernel_params key should be removed from .cfg - not erased.

After applying this fix, CentOS 6.6. unattened install should work again, for example:

avocado run \
   --vt-guest-os Guest.Linux.CentOS.6.6.x86_64 \
   unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads

@luckyh
Copy link
Contributor

luckyh commented Feb 17, 2022

Hi @hpaluch-pil the code looks good to me, would you please check the CI failure and fix it? thanks!

@hpaluch-pil
Copy link
Contributor Author

OK - I signed that commit - it should resolve that "signed-of-by" failure.

@hpaluch-pil
Copy link
Contributor Author

@luckyh
Copy link
Contributor

luckyh commented Feb 17, 2022

I'm unable to see why it failed now: https://github.com/avocado-framework/avocado-vt/runs/5228939021?check_suite_focus=true

@hpaluch-pil I just did a quick check on the last commit (9e891cb) message [1] and it seems the signature was still missing. As your can see from the example below [2] there is a Signed-off-by line under the subject. Please help double confirm that, thanks!

[1] https://patch-diff.githubusercontent.com/raw/avocado-framework/avocado-vt/pull/3342.patch
[2] https://patch-diff.githubusercontent.com/raw/avocado-framework/avocado-vt/pull/3354.patch

@hpaluch-pil hpaluch-pil force-pushed the hpaluch-fix-centos6.6-install branch 2 times, most recently from dbac43b to 62cdd18 Compare February 17, 2022 13:12
@hpaluch-pil
Copy link
Contributor Author

Finally got commit signing right (I hope) using git commit --gpg-sign=KEY_ID -S --amend instead of just git commit -s --amend

@luckyh luckyh merged commit 0d1bf8a into avocado-framework:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants