Skip to content
This repository has been archived by the owner on Aug 8, 2020. It is now read-only.

Add a symbol property to get current option chain's option #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

legendecas
Copy link

close #3

@sindresorhus
Copy link
Member

I missed this as I was not subscribed to this repo.

I don't think the symbol should be exposed. Instead expose a method that gets the options.

It also needs to be documented in the readme.

@@ -1,4 +1,6 @@
'use strict';
const optsSymbol = Symbol('option-chain-opts');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const optsSymbol = Symbol('option-chain-opts');
const optionsSymbol = Symbol('optionChainOptions');

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a symbol property to get current option chain's option
2 participants