hotplug_virtio_mem: updates unplug error message #4171
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test result posted internally, please @yanan-fu @zhenyzha @YongxueHong @zhencliu could you review this PR? Thanks ! |
YongxueHong
reviewed
Oct 4, 2024
Comment on lines
31
to
32
| error_msg = "virtio-mem device cannot get unplugged while 'size' != '0'" | ||
| new_error_msg = "virtio-mem device cannot get unplugged while some of its memory is still plugged" |
There was a problem hiding this comment.
We could still use one parameter error_msg to represent different version's error messages by the regex expression: re.search.
For instance:
error_msg = "virtio-mem device cannot get unplugged while ('size' != '0')|(some of its memory is still plugged)"
Hi @mcasquer
How about it? Please let me know your thoughts.
Thanks.
There was a problem hiding this comment.
@YongxueHong Updated, thanks !
From QEMU 9.1 onwards the error message displayed when the virtio-mem device is tried to be unplugged while it still has some memory plugged has been updated. Adding support for both messages based on the version. Signed-off-by: mcasquer <[email protected]>
mcasquer
force-pushed
the
128_virtio_mem_unplug_message
branch
from
eeddc5e
to
d6f3887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotplug_virtio_mem: updates unplug error message
From QEMU 9.1 onwards the error message displayed when the
virtio-mem device is tried to be unplugged while it still has
some memory plugged has been updated. Adding support for
both messages based on the version.
Signed-off-by: mcasquer [email protected]
ID: 128