fwcfg: Synchronize timeout setting with .au3 file updates #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch increases the `timeout` to 600 seconds and the `step` to 20 seconds in `fwcfg` testcase to align with the updated `.au3` script timings, ensuring synchronization and preventing timing issues during automation framework. Signed-off-by: wji <[email protected]>
|
Test result with fwcfg loop |
|
Hi @leidwang , Could you help review this patch when you are free since it pass on the acceptance test loop? Thanks a lot. |
|
LGTM for this PR, please add the au3 script commit to the issue.Thanks. |
|
Test Result on WS2019 and WinNext |
We should realize that this error is encountered in the testloop, which means we'd better make sure it can pass under the testloop. |
|
Hi @leidwang, Yes, it passes on the single case( including ws2019,ws2022, win11-24h2), fwcfg loop, and acceptance loop like below. |
|
Hi @vivianQizhu, Could you help review this patch and au3 script when you are free? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases the
timeoutto 600 seconds and thestepto 20 seconds infwcfgtestcase to align with the updated.au3script timings, ensuring synchronization and preventing timing issues during automation framework.ID: 1855
Signed-off-by: wji [email protected]